Johannes Sixt <j.sixt <at> viscovery.net> writes: > > From: Johannes Sixt <j6t <at> kdbg.org> > > 8fb3ad76 (fast-import: prevent producing bad delta) introduced the first > use of S_ISUID. Since before this commit the value was irrelevant, we had > only a dummy definition in mingw.h. But beginning with this commit the > macro must expand to a reasonable value. Make it so. > > We do not change S_ISGID from the value 0 because it is used in path.c > (via FORCE_DIR_SET_GID) to set the mode on directories in a manner that > is not supported on Windows, and 0 is the right value in this case. > > Signed-off-by: Johannes Sixt <j6t <at> kdbg.org> > --- > compat/mingw.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/compat/mingw.h b/compat/mingw.h > index 547568b..e2c89d6 100644 > --- a/compat/mingw.h > +++ b/compat/mingw.h > @@ -22,7 +22,7 @@ typedef int socklen_t; > #define S_IWOTH 0 > #define S_IXOTH 0 > #define S_IRWXO (S_IROTH | S_IWOTH | S_IXOTH) > -#define S_ISUID 0 > +#define S_ISUID 04000 > #define S_ISGID 0 > #define S_ISVTX 0 > Ow, it's awkward that the issue was discussed in [1] but slipped and nobody noticed, especially me being a patch sender. If we choose patch from [1] I'd also change a comment to smth like /* * We abuse the 04000 bit on directories to mean "do not delta". * It is a S_ISUID bit on setuid platforms and an unused bit on * non-setuid platforms supported in git. In either case git ignores * the bit, so it's safe to abuse it locally. */ [1] http://thread.gmane.org/gmane.comp.version-control.git/179223/focus=179762 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html