Am 9/20/2011 12:42, schrieb Shumkin Alexey: > On Tue, Sep 20, 2011 at 11:32:54AM +0200, Johannes Sixt wrote: >> Am 9/20/2011 10:07, schrieb Alexey Shumkin: >>> +# hooks.emailcharset >>> +# The charset used in Content-Type header. UTF-8, if not >>> specified. >> >> How can you be sure that the output produced by git log etc. that are >> used in the script are in the encoding specified by this variable? >> IOW, wouldn't log.outputencoding be the better choice to use in the >> Content-Type header? > Yes, you're right, we cannot be sure in UTF-8 encoding of output > and using i18n.logoutputencoding would be a better choice > instead of new config variable. > > But at the present > 1. post-send-mail uses description file of a repo > 2. gitweb also uses this file and AFAIK it assumes one to be in UTF-8 > (I do not know whether it can be changed there but I tested gitweb once long > time ago) > 3. So if i18n.logoutputencoding is not UTF-8 we get a message composed > with mixed encodings. This fact oblidge us to encode headers > (as quoted printable at least) and synchronize body message that contain > repo description (in UTF-8) and diffstat (in i18n.logoutputencoding). > This is a more complicated task for a shell script > than just specifying Content-Type header (may be git-send-email suits here?) In this case, it may make sense to have a separate setting, but you should call git like this: git -c "i18n.logoutputencoding=$emailcharset" show ... git -c "i18n.logoutputencoding=$emailcharset" rev-list --pretty ... -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html