Dmitry Ivankov wrote: > object_count is used to count objects that'll go to the current pack. > While object_count_by_* are used to count total amount of objects and > are not used to determine if current packfile is empty. > > Rename (and move declaration) object_count to pack_object_count to > avoid possible confusion. No strong opinion on this one. I guess the important thing is that you are moving the declaration to the group of declarations labelled as /* The .pack file being generated */ . Is it important to rename the variable while at it (which will disrupt other patches in flight using that variable if they exist)? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html