Jakub Narebski <jnareb@xxxxxxxxx> writes: > So actually now I see that while this line is good to have in esc_html(), > it is not really necessary in sanitize(). > > But anyway we don't want to replace undef with an empty string; undef is > (usually) an error, and we want to catch it, not to hide it. Heh, get off your high horse---whoever wrote such a caller that calls the subroutine and uses its result without checking it against undef is not qualified to make such a statement. I do not think letting "perl -w" notice and complain about an attempt to concatenate undef with string counts as "catching" it. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html