Ramkumar Ramachandra <artagnon@xxxxxxxxx> writes: > Junio C Hamano writes: >> Many symbols that are exported to the global scope do not have to be. >> >> Signed-off-by: Junio C Hamano <junio@xxxxxxxxx> >> --- >> To be applied on top of 3793ac5 (RelNotes/1.7.7: minor fixes, 2011-09-07) >> [...] > > Awesome! I've seen many similar "make-static" patches come up on the > list, but turned down due to code churn issues. I'm happy to finally > see it being merged. Not so fast. We just got a new series from Brandon Casey that adds a new caller to one of the functions that were unused outside a file. Seeing that this happens even inside a relative calm of pre-release feature and code freeze, realize why we call such a change a "churn" and try to avoid it, and imagine how much damage it would have caused if more topics were actively being updated. You should learn to tame your enthusiasm ;-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html