Hi list, This 2-patch series has been rerolled with Jeff's suggestions. For patch 1/2, I've renamed the new test file to t4051-format-patch-config.sh and changed the description to "check that format-patch does not respect porcelain config". In addition, I've slightly reworded the commit message to include the date of the commit (c9bfb953) which introduces the regression. For patch 2/2, as per Jeff's recommendation, teach git_format_config to intercept color.ui in the same way as commit f3aafa4 (Disable color detection during format-patch, 2006-07-09). This is inline with the way we avoid passing down diff.color and color.diff to git_log_config and config functions further down the callchain. Pang Yan Han (2): format-patch: demonstrate that color.ui=always produces colorized patches format-patch: produce non colorized patches when ui.color=always builtin/log.c | 3 ++- t/t4051-format-patch-config.sh | 23 +++++++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletions(-) create mode 100755 t/t4051-format-patch-config.sh -- 1.7.7.rc0.190.gb47b6 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html