On 09/06/2011 03:03 PM, Junio C Hamano wrote: > Brandon Casey <casey@xxxxxxxxxxxxxxx> writes: > >> diff --git a/Makefile b/Makefile >> index 8d6d451..46d9c5d 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -1738,6 +1738,7 @@ endif >> >> please_set_SHELL_PATH_to_a_more_modern_shell: >> @$$(:) >> + @foo=bar_suffix && test bar = "$${foo%_*}" >> >> shell_compatibility_test: please_set_SHELL_PATH_to_a_more_modern_shell > > Perhaps > > @foo='bar?suffix' && test bar = "$${foo%\?*}" > > instead? Looks right. Naohiro, can you test? Or someone else with FreeBSD? make should produce an error message like this: gmake: *** [please_set_SHELL_PATH_to_a_more_modern_shell] Error 1 -Brandon -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html