On Sat, Sep 03, 2011 at 10:36:01PM -0400, Martin von Zweigbergk wrote: > This patch makes format-patch output color escape codes to file when > run with color.ui=always. Before the patch it did not do that. The > documentation for color.ui says "Set it to always if you want all > output not intended for machine consumption to use color". Is > format-patch "intended for machine consumption" or not? Sorry, this is a regression. The old behavior was that commands had to copy color.ui's value manually into diff_use_color_default. With my patch, the value is picked up automatically, and it is up to commands to load or not load the specified config. For diff plumbing versus porcelain, we have separate config code paths (diff_basic versus diff_ui). I forgot that format-patch versus log has the same situation, and needs the same split. It's a long weekend here in the US, but I'll try to get a patch out on Tuesday (and also check for any other similar regressions). > I'm not sure why I had the parameter set to "always" instead of > "true/auto" and maybe I should change it, but since this patch changes > the behavior, I thought I should let you know (it was not mentioned in > the commit message, so I'm not sure it was intentional). Yeah, I don't think setting color.ui to "always" is all that useful. But this behavior change was definitely not intentional. Thanks for noticing. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html