Re: [PATCH v6] Add a remote helper to interact with mediawiki (fetch & push)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes:

> Here:
>
> +	for my $refspec (@refsspecs) {
> +		unless ($refspec =~ m/^(\+?)([^:]*):([^:]*)$/) {
> +			die("Invalid refspec for push. Expected <src>:<dst> or +<src>:<dst>");
> +		}
> +		my ($force, $local, $remote) = ($1 eq "+", $2, $3);
>
> At this point, $force is a boolean saying whether there were a +, and
> $local and $remote are as you can guess.

It may be slightly more Perl-ish to hoist the "0-or-1" outside the group
and rely on $1 becoming undef, like this:

        my ($force, $local, $remote) = $refspec =~ /^(\+)?([^:]*):([^:]*)$/
		or die(...);

Even though it largely is a matter of taste, I think.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]