Brandon Casey <casey@xxxxxxxxxxxxxxx> writes: > From: Brandon Casey <drafnel@xxxxxxxxx> > > Some platforms (IRIX, Solaris) provide an ancient /bin/sh which chokes on > modern shell syntax like $(). SHELL_PATH is provided to allow the user to > specify a working sh, let's use it here. > > Signed-off-by: Brandon Casey <casey@xxxxxxxxxxxxxxx> > --- > t/t6030-bisect-porcelain.sh | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh > index 62125ec..c53af62 100755 > --- a/t/t6030-bisect-porcelain.sh > +++ b/t/t6030-bisect-porcelain.sh > @@ -732,7 +732,7 @@ test_expect_success 'bisect: demonstrate identification of damage boundary' " > git bisect reset && > git checkout broken && > git bisect start broken master --no-checkout && > - git bisect run sh -c ' > + git bisect run \"$SHELL_PATH\" -c ' > GOOD=\$(git for-each-ref \"--format=%(objectname)\" refs/bisect/good-*) && > git rev-list --objects BISECT_HEAD --not \$GOOD >tmp.\$\$ && > git pack-objects --stdout >/dev/null < tmp.\$\$ Hmm, shouldn't we also be quoting '$' in front of SHELL_PATH to make the test_expect_success interpolate the value of SHELL_PATH, instead of hoping that SHELL_PATH does not have double-quote in it when the shell that forms parameters given to test_expect_success interpolates it? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html