The test wrote something along the lines of 0001-foo.patch to output, which of course never contained a signature. Luckily the tested behaviour is actually present. Signed-off-by: Thomas Rast <trast@xxxxxxxxxxxxxxx> --- t/t4014-format-patch.sh | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh index b4d4207..a45d4fb 100755 --- a/t/t4014-format-patch.sh +++ b/t/t4014-format-patch.sh @@ -698,8 +698,8 @@ test_expect_success 'format-patch --no-signature supresses signatures' ' ! grep "^-- \$" output ' -test_expect_failure 'format-patch --signature="" supresses signatures' ' - git format-patch --signature="" -1 >output && +test_expect_success 'format-patch --signature="" supresses signatures' ' + git format-patch --stdout --signature="" -1 >output && check_patch output && ! grep "^-- \$" output ' -- 1.7.7.rc0.370.gdcae57 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html