On Aug 29, 2011, at 1:14 PM, Jeff King wrote:
> On Sun, Aug 28, 2011 at 12:40:56AM -0400, Brian Gernhardt wrote:
>
>> The only usage of poll I see in the credentials system is:
>>
>> credentials-cache--daemon.c
>> 177: if (poll(&pfd, 1, 1000 * wakeup) < 0) {
>>
>> My guess is that (1000 * wakeup) is more than INT_MAX and is becoming
>> negative as the man page for poll seems to indicate that it will fail
>> if timeout < -1.
>>
>> Does anyone familiar with the credentials daemon want to try to figure
>> out a reasonable fix?
>
> Ugh, sorry, this is my fault. The check_expiration() function can return
> a totally bogus value before we actually get any credentials.
>
> Does this patch fix it for you?
Yes it does! Surprisingly enough, non-bogus parameters keeps poll from erroring with EINVAL. Funny that. ;-)
Many thanks,
~~ Brian
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html