Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx> writes:
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx>
I'll leave nitpicking of this patch and helping to improve it to people
who actually have to deal with Hg generated patches for now.
> + hg)
> + this=0
> + for hg in "$@"
> + do
> + this=`expr "$this" + 1`
> + msgnum=`printf "%0${prec}d" $this`
> + # hg stores changeset metadata in #-commented lines preceding
> + # the commit message and diff(s). The only metadata we care about
> + # are the User and Date (Node ID and Parent are hashes which are
> + # only relevant to the hg repository and thus not useful to us)
> + # Since we cannot guarantee that the commit message is in git-friendly
> + # format, we put no Subject: line and just consume all of the message
> + # as the body
Personally I am a bit worried about the phoney "diff --git" output Hg
seems to (be able to) produce. Do they have "index ..." line that express
the blob object names in git terms (implausible), for example? We _might_
want to strip s/diff --git /diff / so that apply won't be confused if that
turns out to be a problem.
Thanks.
> + perl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }
> + if ($subject) { print ; }
> + elsif (/^\# User /) { s/\# User/From:/ ; print ; }
> + elsif (/^\# Date /) {
> + my ($hashsign, $str, $time, $tz) = split ;
> + $tz = sprintf "%+05d", (0-$tz)/36;
> + print "Date: " .
> + strftime("%a, %d %b %Y %H:%M:%S ",
> + localtime($time))
> + . "$tz\n";
> + } elsif (/^\# /) { next ; }
> + else {
> + print "\n", $_ ;
> + $subject = 1;
> + }
> + ' < "$hg" > "$dotest/$msgnum" || clean_abort
> + done
> + echo "$this" > "$dotest/last"
> + this=
> + msgnum=
> + ;;
> *)
> if test -n "$patch_format" ; then
> clean_abort "$(eval_gettext "Patch format \$patch_format is not supported.")"
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html