Sverre Rabbelier <srabbelier@xxxxxxxxx> writes: > 2011/8/26 Junio C Hamano <gitster@xxxxxxxxx>: >> Matthieu Moy <Matthieu.Moy@xxxxxxx> writes: >>> In short, the changes since v3 are: >>> >>> * Adapt to newer Git, which seem to require a "done" command at the >>> end of the fast-import stream. I don't understand why this is >>> needed, since fast-import is called without the --done flag by >>> remote-helpers, but if I don't do this, "git fetch" doesn't >>> terminate and keeps waiting ... >> >> Hmmmm, is this a regression in fast-import? Can this be bisected if so? > > We agreed that making this change is the best way to go forward, since > there's so few (read: none) remote-helpers yet, the fix is trivial, > and it solves a design mistake while the api is not yet set in stone. Does this exchange suggest that at least we would need an update to documentation around "done", as Matthieu's "why is 'done' needed even though I am not calling with --done?" sounds like a very fair question. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html