On 08/26/2011 01:27 PM, Linus Torvalds wrote: > On Thu, Aug 25, 2011 at 3:37 PM, Boaz Harrosh <bharrosh@xxxxxxxxxxx> wrote: >> >> Add a .gitattributes file to the Linux tree to enable cpp parsing >> of the source files. > > Hmm. I'm not entirely conviced. If people really think that the hunk > description matters that much, maybe we should just instead improve on > the automatic diff detection, and extend it from just binary-vs-text, > to also do the common hunk-headers. > > After all, not having a diff pattern already *does* mean "automatic", > so it would be just a rather trivial extension to that. > > Junio? > There was a patch submitted for new git version to auto detect file extensions and do the right thing. (Look for the thread "git diff annoyance / feature request" on the git mailing list) But this patch is for all the people and distributions that are going to use the old git versions for a while, (Years). It is important for the Linux mailing-list review, because you get patches with: @@@ lable out: - change foo + to bazz And how the hell are you suppose to know where in the file it is. This is such a trivial addition, that can help unify everyone's usage. I don't see the down sides. Thanks Boaz > Linus -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html