Jeff King <peff@xxxxxxxx> writes: > No, certainly not since 122aa6f (diff: introduce diff.<driver>.binary, > 2008-10-05). That commit's message claims that we did before it, but > looking at the patch, I am not so sure. But I'm not about to start > testing a 3-year-old patch to see if it really was the source of the > fix; the point is that it is correct now. :) Violently agreed ;-) > I think it could be a problem in the future if the builtin userdiff > drivers started growing more invasive options, like automatically > claiming to be non-binary (i.e., setting diff.cpp.binary = false by > default). Well, I think we can be careful when we start thinking about doing something complex like that, then. Mentioning the above consideration in the commit message of the final version of this patch would probably be a good idea, I presume. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html