git diff has this very annoying miss-fixture where it will state
as hunk header the closest label instead of the function name.
So I get:
@@ -675,9 +670,23 @@ try_again:
}
if (flag) {
- foo();
+ bazz();
}
Instead of what I'd like:
@@ -563,12 +563,7 @@ static int write_exec(struct page_collect *pcol)
}
if (flag) {
- foo();
+ bazz();
}
I mean. The label "try_again" is not at all unique in my file. As a
reader I would like to see where is that code going to. The function
name is a unique file identifier that tells me exactly where the change
is going. The label is not. (It's not freaking BASIC)
I bet all this was just inherited from diff. Would it be accepted if
I send a patch to fix it? What you guys think a goto label makes any
sense at all?
Thanks
Boaz
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html