Andreas Schwab wrote: > $ git grep S_ISUID > compat/mingw.h:#define S_ISUID 0 Good catch, thanks. Fix below --- despite appearances, this "mode" field is about tree objects in the repository and there is no need to match the current platform's file status conventions. Another worrisome detail is that the patch changes the semantics of tree_entry.versions[0].mode (by introducing the NO_DELTA bit) without changing its name. It would be safer to rename it to te_mode or something. Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx> --- diff --git i/fast-import.c w/fast-import.c index 95919b63..45e2128a 100644 --- i/fast-import.c +++ w/fast-import.c @@ -173,7 +173,7 @@ Format of STDIN stream: /* * We abuse the setuid bit on directories to mean "do not delta". */ -#define NO_DELTA S_ISUID +#define NO_DELTA 04000 struct object_entry { struct pack_idx_entry idx; -- -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html