On Thu, Aug 18, 2011 at 4:18 PM, Pete Wyckoff <pw@xxxxxxxx> wrote: > This is a good idea. But I notice that -M, -C, -B can take > a diverse set of option forms, including floating point and > optional "%". "-B" can take two args, separated by a "/". > > See diff_scoreopt_parse(). It would be weird for git-p4 to limit > that set to integers like you do here. > > Would you be willing to change it to pass the string blindly? > Just filter out the special values, and pass everything else > unchanged. > > "true" -> "-M" > "false" -> "" > "" -> "" > ".*" -> "\1" This makes sense. I did notice that -M and -C supported, at least, a '%' char at the end. But I decided to ignore it. I think your is idea is not only good, but also a simpler solution. I'll send a new set of patches shortly with this implemented. > Dunno if you care about --break-rewrites. Just pointing to it > as a similar option to -M and -C in case you missed it. I was completely unaware of this option, so I don't feel comfortable in adding it as a configuration option for now. Will need to understand it first ;) -- Vitor Antunes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html