I think this makes a lot more sense than the other option of looking up graft points every time, as we expect only a handful of grafts, if any, exist in a repository. If you have, on the other hand, tons of historical graft points, and you are viewing only near the tip (e.g. "log -20"), this implimentation still calls lookup_commit() for all those historical graft points that are likely to be scattered further back in the packfile, and the performance may suffer. But that is what it means when we say that we are optimized for use case where only a handful of grafts exist, so it is not something that we worry about too much. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html