2011/8/16 Junio C Hamano <gitster@xxxxxxxxx>: > Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > >> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> >> --- > > What is this for? No explanation? Um.. for stopping emitting diff when the consumer feels enough and wants no more. Will update. >> @@ -64,10 +64,12 @@ static void consume_one(void *priv_, char *s, unsigned long size) >> unsigned long this_size; >> ep = memchr(s, '\n', size); >> this_size = (ep == NULL) ? size : (ep - s + 1); >> - priv->consume(priv->consume_callback_data, s, this_size); >> + if (priv->consume(priv->consume_callback_data, s, this_size)) >> + return -1; >> size -= this_size; >> s += this_size; >> } >> + return 0; >> } > > Returning a negative value implies that this is an error condition. Should > all "non-zero" returns from ->consume necessarily be considered error? Perhaps negative values only, like how xdiff treats it. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html