Fredrik Gustafsson <iveqy@xxxxxxxxx> writes: > diff --git a/git-submodule.sh b/git-submodule.sh > index bc1d3fa..ace6c1d 100755 > --- a/git-submodule.sh > +++ b/git-submodule.sh > @@ -122,14 +122,53 @@ module_clone() > path=$1 > url=$2 > reference="$3" > + gitdir= > + gitdir_base= > + name=$(module_name "$path") > + if test -z "$name" > + then > + name="$path" > + fi This conditional is not needed; module_name dies when it cannot find the name for the path, as it should. If the defaulting to the path itself were a good idea (which I do not think it is), that should be done in module_name so that other callers that tried to find the name for a given path that does not have a named module would get a consistent result. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html