Ramkumar Ramachandra wrote: > The format_todo function leaks memory because it forgets to call > free_message after get_message. It is a potentially big leak, because > fresh memory is allocated to store the commit message message for each > commit. Fix this. Reading this, I think, "why does formatting an insn list require all these heavy memory allocations?". So while the patch looks good to me, I start to wonder if something using find_commit_subject() directly would not be easier. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html