This patch series adds comments for some non-obvious things in attr.c, simplifies the interface of parse_attr(), and unrolls the loop over passes in parse_attr_line() (which IMO makes the code easier to understand). It does not change the observable behavior in any way. The patch series is against master, but can be rebased to next without conflicts. Michael Haggerty (7): Add a file comment Document struct match_attr Increment num_attr in parse_attr_line(), not parse_attr() Change parse_attr() to take a pointer to struct attr_state Determine the start of the states outside of the pass loop Change while loop into for loop Unroll the loop over passes attr.c | 113 +++++++++++++++++++++++++++++++++++---------------------------- 1 files changed, 63 insertions(+), 50 deletions(-) -- 1.7.6.8.gd2879 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html