Ramkumar Ramachandra wrote:
> The format_todo function leaks memory because it forgets to call
> free_message after get_message. Fix this.
>
> Suggested-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
> Signed-off-by: Ramkumar Ramachandra <artagnon@xxxxxxxxx>
That's "Reported-by", I think. :)
Is this a big leak or a small one? Is it one-time or in a loop?
> ---
> builtin/revert.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/builtin/revert.c b/builtin/revert.c
> index a548a14..1a4187a 100644
> --- a/builtin/revert.c
> +++ b/builtin/revert.c
> @@ -688,6 +688,7 @@ static int format_todo(struct strbuf *buf, struct commit_list *todo_list,
> return error(_("Cannot get commit message for %s"), sha1_abbrev);
> strbuf_addf(buf, "%s %s %s\n", action_str, sha1_abbrev, msg.subject);
> }
> + free_message(&msg);
> return 0;
> }
I don't see how this could work. Since there an xmalloc() in each
loop iteration, I would have expected the free() to be in the loop
body, too.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html