Re: [PATCH 01/40] test-cleaner: automate whitespace cleaning of test scripts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Aug 6, 2011 at 6:44 PM, Jon Seymour <jon.seymour@xxxxxxxxx> wrote:
> This script allows the automated cleaning of test scripts.
>
> Any whitespace fixups of a test script that do not effect the
> exit status or output of the test are assumed to be safe
> and are automatically committed.

Actually, this is not true - commits are generated, if the file
matches the filtering criteria for the fix subcommand specified.

> If no arguments are supplied, file arguments are read from stdin.

Should I use - for instead?

> +
> +fix_whitespace_auto()
> +{
> +       check_whitespace "$@" 2>/dev/null | grep "^AUTO" | fix_whitespace
> +}
> +
> +fix_whitespace_auto()
> +{
> +       check_whitespace "$@" 2>/dev/null | grep "^MANUAL" | fix_whitespace
> +}

Both these need cut -f1 before the fix_whitespace stage.

jon.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]