Re: [PATCH] Tolerate zlib deflation with window size < 32Kb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4 August 2011 00:56, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> roberto.tyley@xxxxxxxxx writes:
> > -     if (map[0] == 0x78 && !(word % 31))
> > +     if ((map[0] & 0x88) == 0x08 && !(word % 31))
>
> Are you sure about this 0x88? Isn't it 0x8F or something?

Ah- yes, you're right - the bitmask should be 0x8F, because the
lower nibble of a deflated zlib stream is 8 (8=deflate) and we want
to match all 4 bits.

Thankfully the rest of the logic still applies - I'll submit an
updated patch in a minute, once I've conquered my embarrassment :-)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]