This re-roll differs in the following ways from v2: * The following series of refactoring patches were inserted: Teach prepare_attr_stack() to figure out dirlen itself Extract a function collect_all_attrs() Remove redundant call to bootstrap_attr_stack() Remove redundant check This change, in turn, simplifies patch Allow querying all attributes on a file * The new API function is named git_all_attrs() instead of git_allattrs(). * Additionally, git_checkattr() is renamed to git_check_attr() at the suggestion of Junio. * The renaming of struct git_attr_check to git_attr_value is no longer part of the patch series. Thanks to Junio for the great feedback. I believe that I have addressed all of your comments. Michael Haggerty (23): doc: Add a link from gitattributes(5) to git-check-attr(1) doc: Correct git_attr() calls in example code Remove anachronism from comment Disallow the empty string as an attribute name git-check-attr: Add missing "&&" git-check-attr: Add tests of command-line parsing Provide access to the name attribute of git_attr git-check-attr: Use git_attr_name() Teach prepare_attr_stack() to figure out dirlen itself Extract a function collect_all_attrs() Remove redundant call to bootstrap_attr_stack() Remove redundant check Allow querying all attributes on a file git-check-attr: Extract a function output_attr() git-check-attr: Introduce a new variable git-check-attr: Extract a function error_with_usage() git-check-attr: Handle each error separately git-check-attr: Process command-line args more systematically git-check-attr: Error out if no pathnames are specified git-check-attr: Add an --all option to show all attributes git-check-attr: Drive two tests using the same raw data git-check-attr: Fix command-line handling to match docs Rename git_checkattr() to git_check_attr() Documentation/git-check-attr.txt | 23 ++++- Documentation/gitattributes.txt | 3 + Documentation/technical/api-gitattributes.txt | 63 +++++++++----- archive.c | 2 +- attr.c | 79 ++++++++++++---- attr.h | 20 ++++- builtin/check-attr.c | 121 +++++++++++++++++-------- builtin/pack-objects.c | 2 +- convert.c | 2 +- ll-merge.c | 4 +- t/t0003-attributes.sh | 61 +++++++++---- userdiff.c | 2 +- ws.c | 2 +- 13 files changed, 272 insertions(+), 112 deletions(-) -- 1.7.6.8.gd2879 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html