Re: [PATCH v16 5/7] bisect: introduce --no-checkout support into porcelain.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jon Seymour <jon.seymour@xxxxxxxxx> writes:

> +bisect_head()
> +{
> +	if test -f "$GIT_DIR/BISECT_HEAD"; then
> +		echo BISECT_HEAD;
> +	else

	if test -f ...
        then
        	echo BISECT_HEAD
	else

> +	    --no-checkout)
> +		mode=--no-checkout;

You seem to be very fond of extraneous semicolons.

Also I very much prefer to write "then" on its own line, indented at the
same level as "if". Consistently doing so will make your if statement a
lot easier to read when some of them need to have multi-line conditionals.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]