On Wednesday 03 August 2011 17:13:13 Jon Seymour wrote: > On Thu, Aug 4, 2011 at 12:09 AM, Christian Couder > <christian.couder@xxxxxxxxx> wrote: > > On Wed, Aug 3, 2011 at 3:24 PM, Jon Seymour <jon.seymour@xxxxxxxxx> wrote: > >> Mmmm. > >> > >> Actually, there is a neater way to do this. > >> > >> I'll such use the existence of BISECT_HEAD to inform the > >> implementation of bisect_mode(). > >> > >> This avoids the need for a separate .git/BISECT_MODE file. > > > > Yeah, but then you have to be careful of the fact that BISECT_HEAD > > might have not been properly deleted or might have been created by the > > user for other purposes. > > I have removed $GIT_DIR/BISECT_MODE in v15. > > If BISECT_HEAD was being used for other purposes, it is going to get > deleted anyway, irrespective of whether we have a separate BISECT_MODE > file, so I am not sure we need to consider that when deciding when we > need a separate BISECT_MODE file. Yeah, I was probably worrying too much. > FWIW: bisect_mode() was only going to get called from one place so I > just inlined the implementation in that place. (on the call to > bisect--helper). Ok. Thanks, Christian. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html