On Thursday 28 July 2011 18:52:25 Ramkumar Ramachandra wrote: > > @@ -780,7 +789,13 @@ int cmd_revert(int argc, const char **argv, const char > *prefix) opts.action = REVERT; > git_config(git_default_config, NULL); > parse_args(argc, argv, &opts); > - return pick_commits(&opts); > + > + /* > + * Decide what to do depending on the arguments; a fresh > + * cherry-pick should be handled differently from an existing > + * one that is being continued > + */ It is strange to me that you add this comment only here and not below in cmd_cherry_pick(). So I'd suggest to put it before the definition of pick_revisions() instead. > + return pick_revisions(&opts); > } > > int cmd_cherry_pick(int argc, const char **argv, const char *prefix) > @@ -791,5 +806,5 @@ int cmd_cherry_pick(int argc, const char **argv, const > char *prefix) opts.action = CHERRY_PICK; > git_config(git_default_config, NULL); > parse_args(argc, argv, &opts); > - return pick_commits(&opts); > + return pick_revisions(&opts); > } Thanks, Christian. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html