Jakub Narebski <jnareb@xxxxxxxxx> writes:
> "git config -z -l" that gitweb uses in git_parse_project_config() to
> populate %config hash returns section and key names of config
> variables in lowercase (they are case insensitive). When checking
> %config in git_get_project_config() we have to take it into account.
>
> Gitweb does not (yet?) use git config variables with subsection, so we
> can simply lowercase $key in git_get_project_config (only subsection
> names are case sensitive).
Why stop there, I have to wonder, instead of futureproofing with minimum
cost, even with something naïve like:
if (my ($hi, $mi, $lo) = ($key =~ /^([^.]*)\.(.*)\.(.*)$)) {
$key = join(".", lc($hi), $mi, lc($lo);
} else {
$key = lc($key);
}
> Signed-off-by: Jakub Narebski <jnareb@xxxxxxxxx>
> ---
> I think it is a resend, but I haven't found first version.
>
> The patch is unchanged, but commit message got improved.
> It is not as much bugfix as hardening (against user e.g. adding
> new overridable feature via gitweb config file).
>
> gitweb/gitweb.perl | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 1070805..90b5a73 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -2526,6 +2526,7 @@ sub git_get_project_config {
>
> # key sanity check
> return unless ($key);
> + $key = lc($key); # assuming there is no subsection
> $key =~ s/^gitweb\.//;
> return if ($key =~ m/\W/);
>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html