On Sun, Jul 24, 2011 at 9:59 PM, Jon Seymour <jon.seymour@xxxxxxxxx> wrote:
> @@ -173,7 +173,6 @@ int cmd_ls_tree(int argc, const char **argv, const char *prefix)
> tree = parse_tree_indirect(sha1);
> if (!tree)
> die("not a tree object");
> - read_tree_recursive(tree, "", 0, 0, &pathspec, show_tree, NULL);
> + return read_tree_recursive(tree, "", 0, 0, &pathspec, show_tree, NULL);
>
> - return 0;
Nit picking. Most programs return positive value (usually 1) for error
cases here. read_tree_recursive may return -1 (which turns out to be
255). Also removing the last blank line in this function would be
nice.
--
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html