Jon Seymour <jon.seymour@xxxxxxxxx> writes:
> In the case of a corrupt repository, git ls-tree may report an error but
> presently it exits with a code of 0.
>
> This change uses the return code of read_tree_recursive instead.
>
> Improved-by: Jens Lehmann <Jens.Lehmann@xxxxxx>
> Signed-off-by: Jon Seymour <jon.seymour@xxxxxxxxx>
> ---
> builtin/ls-tree.c | 6 +++---
> t/t3103-ls-tree-missing-tree.sh | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/builtin/ls-tree.c b/builtin/ls-tree.c
> index f08c5b0..6d6c992 100644
> --- a/builtin/ls-tree.c
> +++ b/builtin/ls-tree.c
> @@ -120,7 +120,7 @@ int cmd_ls_tree(int argc, const char **argv, const char *prefix)
> {
> unsigned char sha1[20];
> struct tree *tree;
> - int i, full_tree = 0;
> + int i, full_tree = 0, err;
> const struct option ls_tree_options[] = {
> OPT_BIT('d', NULL, &ls_options, "only show trees",
> LS_TREE_ONLY),
> @@ -173,7 +173,7 @@ int cmd_ls_tree(int argc, const char **argv, const char *prefix)
> tree = parse_tree_indirect(sha1);
> if (!tree)
> die("not a tree object");
> - read_tree_recursive(tree, "", 0, 0, &pathspec, show_tree, NULL);
> + err = read_tree_recursive(tree, "", 0, 0, &pathspec, show_tree, NULL);
>
> - return 0;
> + return err;
> }
Makes sense. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html