Jeff King <peff@xxxxxxxx> writes: >> > +`credential_reject`:: >> > + >> > + Inform the credential subsystem that the provided credentials >> > + have been rejected. This will clear the username and password >> > + fields in `struct credential`, as well as notify any helpers of >> > + the rejection (which may, for example, purge the invalid >> > + credentials from storage). >> >> What hints do helpers get when this is called? Do they get username, >> unique and description to allow them to selectively purge the bad ones >> while keeping good ones, or the username is already cleared by the time >> the helpers are notified and they have no clue? > > They get username, unique, and description, to let them purge the > minimal amount (they are always free to ignore the username and purge > more, of course, if they are backed by less-capable storage). > > We could also... Ahh, that wasn't what I was getting at. I was only reacting to the order of events described in "clear them, as well as notify" (as if these cleared information is no longer available to be used to nitify) and asking for clarification. As long as enough information is sent to the helper to selectively purge stale/mistyped information so that it can ask again, I am perfectly happy. >> The document did not say anything about escaping/quoting of values, but it >> may not be a bad idea to make it more explicit over there. > > There is no quoting or escaping. As the document says, "the value may > contain any bytes except a newline". It doesn't mention that keys cannot > contain an "=" or a newline, though that is also true. This also was a documentation comment; "may contain any bytes" can be followed with "and used as-is" and I wouldn't have been confused. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html