Re: [PATCH 06/14] introduce credentials API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 21, 2011 at 02:59:31PM -0700, Junio C Hamano wrote:

> Jeff King <peff@xxxxxxxx> writes:
> 
> > diff --git a/credential.c b/credential.c
> > new file mode 100644
> > index 0000000..c403289
> > --- /dev/null
> > +++ b/credential.c
> > @@ -0,0 +1,190 @@
> > ...
> > +void credential_fill(struct credential *c, const struct string_list *methods)
> > +{
> > +	...
> > +	}
> > +	die(err.buf);
> 
> credential.c:195: error: format not a string literal and no format arguments
> 
> This needs to be
> 
> 	die("%s", err.buf);

Thanks, silly me. I'm surprised I didn't get a warning, as I compile
with -Wall. Is there an extra flag you need to give gcc?

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]