Re: [PATCH] Makefile: add Minix configuration options.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thomas Cort <tcort@xxxxxxxxxx> writes:

>  * Adds a $(uname_S) case for Minix with the correct options.

Ok, but lose the asterisk and speak as if you are giving an order to the
codebase or the person who maintains it, i.e. "Add $(uname_S) case...".

>  * Adds NEEDS_SSL_WITH_CURL and NEEDS_CRYPTO_WITH_SSL to the
>    libcurl section. On Minix both -lssl and -lcrypto are
>    needed when using -lcurl.

These...

> +	NEEDS_IDN_WITH_CURL = YesPlease
> +	NEEDS_SSL_WITH_CURL = YesPlease

... are not described in the beginning of Makefile; add them.

>  * Changes OPENSSL_LINK to OPENSSL_LIBSSL in the
>    NEEDS_CRYPTO_WITH_SSL conditional in the libopenssl section.

Why is this change necessary?

>    The -lcrypto needs to be in OPENSSL_LIBSSL.

Ditto.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]