Chris Wilson wrote: > Hi, > > We are using Sentry (a C/C++ static analysis tool) to analyze > git on a nightly basis. Sentry found that a file leak > was recently introduced in the commit 924aaf3. Hmmm ..., commit 924aaf3 did *not* introduce a file handle leak. It would seem that the change in scope of the file handle made it easier for Sentry to see the *existing* (potential) file handle leak. no? Other than that, ... ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html