Ramkumar Ramachandra wrote: > New commit message. > > revert: Separate cmdline parsing from functional code > > Currently, revert_or_cherry_pick sets up a default git config, parses > command-line arguments, before preparing to pick commits. This makes > for a bad API as the central worry of callers is to assert whether or > not a conflict occured while cherry picking. The current API is like: > > if (revert_or_cherry_pick(argc, argv, opts) < 0) > print "Something failed, I'm not sure what" Nice. That's much clearer. [...] > Later in the series, pick_commits will serve as the starting point for > continuing a cherry-pick or revert. With the addition of "also" between will and serve, it looks good to me now. Thank you. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html