Ramkumar Ramachandra wrote: > Yes. Thanks. How about this? > > revert: Eliminate global "commit" variable > > Prior to v1.7.2-rc1~4^2~7 (revert: allow cherry-picking more than one > commit, 2010-06-02), the file-scope static "commit" variable used to > represent one of the arguments passed to the "git cherry-pick" or "git > revert". This was not changed after cherry-pick learnt to replay Meh, I prefer the version starting with "Functions which act on commits", which was already readable and not too confusing. The point of the just-so story I wrote is that the "commit" variable was probably static _because_ of an analogy with command-line options that needed to be static to be pointed to by the "struct options" initializer. But that is not a very important detail; it just helped my understanding. Regards, Jonatahn -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html