On Fri, Jul 08, 2011 at 12:25:00AM +0200, Erik Faye-Lund wrote: > On Thu, Jul 7, 2011 at 9:15 PM, Jeff King <peff@xxxxxxxx> wrote: > > On Thu, Jul 07, 2011 at 01:43:09PM +0200, Erik Faye-Lund wrote: > > > >> The POSIX-function fork is not supported on Windows. Use our > >> start_command API instead. > > > > Is start_command the right solution? From my reading, the fork is > > actually because we want to set up a sideband multiplexer. Should we not > > just be using start_async() to start a thread, as we do in receive-pack? > > I considered that, but discarded it because I figured it required me > to plug through a file descriptor all the way through the code. But > perhaps I was wrong, and dup2 will make that job a lot easier? Yeah, exactly. The current code is already using dup2 in the same way. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html