On Thu, Jul 7, 2011 at 1:57 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Tay Ray Chuan <rctay89@xxxxxxxxx> writes: > >> Group free()'s that are called when a malloc() fails in >> xdl_prepare_ctx(), making for more readable code. > > Nicer, but I wonder if we can get away with a single label that lets us > abort with freeing whatever we have allocated by making sure that the > various pointer fields and variables are initialized to NULL, which may > lead to even more readable code. Pardon my dullness. Do you mean to check if the various fields are set to NULL upon allocation, and free()'ing them if so? -- Cheers, Ray Chuan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html