Re: [PATCH 2/5] svn-fe: allow svnadmin instead of svnrdump in svn helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Dmitry Ivankov writes:
> svnrdump produces the same stream as svnadmin dump. svnrdump is able
> to do it via any svn remote protocol while svnadmin needs access to
> the repository filesystem and can't produce subdirectory dumps.
> But svnrdump is a newer tool and may be unavailable on some systems.
>
> Try to use svnadmin dump for file:// repository urls if there is no
> svnrdump in the PATH. First of all this is to be used in tests, where
> the repository is indeed local most of the time.

svnrdump's output is not identical to svnadmin's output.  You'd
perhaps want to document the differences, and the impact they might
have?

> diff --git a/contrib/svn-fe/git-remote-svn-alpha b/contrib/svn-fe/git-remote-svn-alpha
> index 61c9b07..84d841e 100755
> --- a/contrib/svn-fe/git-remote-svn-alpha
> +++ b/contrib/svn-fe/git-remote-svn-alpha
> @@ -12,10 +12,32 @@ usage () {
>        exit 129
>  }
>
> +try_svnrdump () {
> +       command -v svnrdump >/dev/null &&
> +       echo "svnrdump dump --non-interactive --username=Guest --password= \
> +               --quiet --incremental" ||
> +       true
> +}

I saw this '--username', '--password' in other patches too.  I'm
probably missing context, but I'm curious to know why this is required
and what you're planning to do to fix it in the future.

Thanks.

-- Ram
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]