On 29/11/06, Pavel Roskin <proski@xxxxxxx> wrote:
When calculating the string to be used in the From: field, don't require it to come from the configuration file. Instead, reuse already known authname and authemail values as the default. They can be taken from the GIT_AUTHOR_NAME and GIT_AUTHOR_EMAIL environment variables.
Your patch uses the author of the patch which can be different from the person sending the e-mail. It could indeed use the author from GIT variables or configuration (not the patch author) and I already have a patch from Karl Hasselström for this (which I haven't found the time to check properly). The reason I added a sender option is because the sender (that gets added to the e-mail headers) may differ from the author of the patch. I use one e-mail address as the author but I might be behind an SMTP server which only allows a different e-mail address and therefore I set the sender accordingly. Once I merge Karl's patch, I'll modify StGIT to use the GIT defaults if there is no sender configured. -- Catalin - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html