Frédéric Heitzmann <frederic.heitzmann@xxxxxxxxx> writes:
> Le 02/07/2011 15:54, Matthieu Moy a écrit :
>> Frédéric Heitzmann<frederic.heitzmann@xxxxxxxxx> writes:
>>
>>> The 'pre-svn-dcommit' hook si called before 'git svn dcommit', which aborts
>>> if return value is not zero.
>>> ---
>>> git-svn.perl | 19 +++++++++++++++++++
>> What about documentation?
> Should documentation be part of githooks or git-svn man page ?
> I vote for the latest, in order to avoid
I'd also put it in the git-svn page, since git-svn is somehow not really
part of Git.
> +prevent some diff to be committed to a SVN repository.
I'd say "an SVN", not "a SVN", but the documentation already use both
forms.
>>> + if ($? == -1) {
>>> + print "[pre_svn_dcommit_hook] failed to execute $hook:
>>> $!\n";
>> whitespace damage (extra newline)
>>
>
>As for the 'whitespace damage", I do not understand what you mean.
>The \n look mandatory to me.
>You may look at 'info perlfunc' for the original code snippet (see
>system' function).
I'm not talking about the \n, but the fact that what used to be a single
line of code is broken in two parts in your message.
A patch hunk has lines starting with " ", "+" or "-", yours have a line
starting with $. It won't apply with "patch" or "git apply", hence extra
work for our maintainer.
Try using "git send-email" to avoid that.
And actually, read Documentation/SubmittingPatches, in particular the
part about Signed-off-by.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html