Jonathan Nieder wrote: > Ramkumar Ramachandra wrote: >> Although pick_commits checks the validity of the >> replay_opts strucutre before before starting its operation, this is >> fragile design because the validity of the replay_opts structure >> depends on pick_commits being called before anything else. > > Thanks, that's a bit more concrete. But it's not fragile, is it? > pick_commits() is the entry point to the cherry-pick machinery --- > anything that uses a struct replay_opts is called indirectly by > pick_commits(), no? Perhaps the idea is that in the future, there will be multiple entry points? Again, the questions the reader will have are: - what is wrong with the code? (i.e., assume I'm a total stick in the mud and convince me there needs to be *some* change) - why does the current code work at all? - what is the proposed fix? - how will it work better? - what are the downsides, and how does the patch mitigate them? Exact wording does not matter, as long as those questions are answered. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html