Hi Junio,
Junio C Hamano writes:
> Ramkumar Ramachandra <artagnon@xxxxxxxxx> writes:
>
>> diff --git a/builtin/revert.c b/builtin/revert.c
>> index 5c0b97e..eb68068 100644
>> --- a/builtin/revert.c
>> +++ b/builtin/revert.c
>> @@ -46,6 +46,9 @@ enum replay_action { REVERT, CHERRY_PICK };
>> struct replay_opts {
>> enum replay_action action;
>>
>> + /* --skip-all */
>> + int skipall_oper;
>
> Yikes what is that "oper" doing there? Don't truncate a word in the
> middle only to shorten names and make it unclear what you want to say. Is
> that operand? operation? In this case, I think "int skip_all" is
> sufficient, and you can lose the comment that adds no extra information.
Interesting side note: I'd initially wanted to use "skip_all" and
"continue", but "continue" is a C keyword. That's why I'd reluctantly
suffixed "_oper" to both for consistency.
-- Ram
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html