Re: [PATCH] stash: Add --include-untracked option to stash and remove all untracked files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



David Caldwell <david@xxxxxxxxxxxx> writes:

> The --include-untracked option acts like the normal "git stash save" but
> also adds all untracked files in the working directory to the stash and then
> calls "git clean --force --quiet"

Great you did it, that's indeed something I missed with git stash.

> +	(test -z "$untracked" || test -z $(untracked_files))

Shouldn't there be double quotes around $(untracked_files)?

> +		-u|--include-untracked)
> +			untracked=untracked
> +			;;
> +		-a|--all)
> +			untracked=all
> +			;;

I first thought of --all as a complement of --include-untracked, but in
your proposal, a simple

  git stash --all

is accepted. If you go this way, maybe there should be more symetry in
option naming. For example, --all could be --include-ignored.

Or you can consider that --all is short and sweet, and go for it ;-).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]