Junio, Sorry for the repeat, accidentally sent as HTML, rejected by the list. On Thursday, June 23, 2011, Junio C Hamano wrote: David Barr <davidbarr@xxxxxxxxxx> writes: > One struct to capture all types, just 4 methods: decode_message, > encode_message, sizeof_message, hash_field. Adding to the review from yesterday, hash_field() looked quite out of place. If you are going to implement a hash table that holds protobuf objects in a separate file/module, I would imagine the function belongs there, not here. I agree completely, another artifact of refactoring from experimental code. -- David Barr -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html