Ramkumar Ramachandra wrote: > Currently, revert_or_cherry_pick does too many things including > argument parsing and setting up to pick the commits; this doesn't make > a good API. Simplify and rename the function to pick_commits, so that > it just has the responsibility of setting up the revision walker and > calling do_pick_commit in a loop. Transfer the remaining work to its > callers cmd_cherry_pick and cmd_revert. Makes sense to me. :) > Later in the series, > pick_commits will serve as the starting point for continuation. This sentence is a little cryptic. The naive reader wonders "continuation of what?" -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html